Simone
3cd1d6e0a6
The driver reached the PCU function's config space by walking the ACPI MCFG
table and mapping the ECAM page itself. That is one leaf driver deciding
config-space policy, and no other driver in mainline does it, so it was the
single most likely reason for a NAK.
Move that decision where it belongs: the upstream series is now two patches,
a PCI/x86 accessor that forces the memory-mapped path with the core's
locking, and this driver on top of it. Reviewers on each side now get
something they can act on, and get_maintainer.pl selects the PCI and x86
people by itself.
Correctness work in the same pass:
- the completion bits are latched, so a command the engine never accepted
was indistinguishable from a completed one and returned the previous
transaction's data as valid. Require a positive sign that the engine
acted on the command;
- compare the command registers after every transfer against what the
driver left in them and fail with -EAGAIN on a mismatch. The original
iMC driver had this check and it is what makes an unarbitrated system
detectable instead of silently wrong;
- use the i2c core's suspended-adapter mechanism rather than a private
flag and -EHOSTDOWN;
- use devm_mutex_init(), drop the unnecessary pci_enable_device(), and
return -ENODEV rather than -EPERM from the default-off gate, which was
printing a driver-core error on every boot;
- mask GO when restoring a saved command word.
Stop attributing the dropped CF8/CFC write to System Management Mode. The
only evidence was a boot log line naming the access method, which says
nothing about who filters the write. tools/probe-cf8-write.sh is there to
settle it with an MSR_SMI_COUNT measurement.
Add Documentation/i2c/busses/i2c-imc-skylake.rst, which every other PC SMBus
driver has and which was explicitly asked for on the 2020 iMC thread, the
tools/ scripts for the hardware measurements the submission still owes, and
compat/pci-mmcfg-compat.h so the driver still builds out-of-tree against a
kernel without the new accessor while the source stays byte-identical to the
submitted patch.
59 lines
899 B
Plaintext
59 lines
899 B
Plaintext
# Kernel build artifacts & temporary files
|
|
*.ko
|
|
*.ko.zst
|
|
*.mod
|
|
*.mod.c
|
|
*.mod.o
|
|
*.o
|
|
*.a
|
|
*.s
|
|
.*.cmd
|
|
.tmp_versions/
|
|
modules.order
|
|
Module.symvers
|
|
/i2c-imc-skylake.mod
|
|
|
|
# C/C++ Developer tools and symbol databases
|
|
*.d
|
|
*.o.d
|
|
compile_commands.json
|
|
.clangd/
|
|
.cache/
|
|
tags
|
|
TAGS
|
|
GPATH
|
|
GRTAGS
|
|
GSYMS
|
|
GTAGS
|
|
|
|
# IDEs and Editors
|
|
.vscode/
|
|
.idea/
|
|
*.swp
|
|
*.swo
|
|
*~
|
|
*.code-workspace
|
|
|
|
# OS-specific files
|
|
.DS_Store
|
|
Thumbs.db
|
|
|
|
# Generated patch files (git format-patch output)
|
|
patches/
|
|
|
|
# Internal working documents (not for public repo)
|
|
TODO.md
|
|
docs/archive-submission-analysis.md
|
|
README.local.md
|
|
AGENTS.md
|
|
docs/mainline-plan.md
|
|
docs/archive-i2c-imc-driver-plan.md
|
|
docs/archive-v3-review-fixes.md
|
|
docs/submission/submission-instructions.md
|
|
docs/submission/review-answers.md
|
|
docs/submission/v3-readiness-audit.md
|
|
docs/submission/v4-review-360.md
|
|
|
|
# Private Gitea CI (replaced by .github/workflows/ for public repo)
|
|
.gitea/
|