Simone/local-ci-cd-system
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(template): Fix Git skip path + 7-Zip PATH injection

Browse Source 
Two root causes:
1. Git skip check used C:\BuildTools\Git but Git installs to
   C:\Program Files\Git (default). Changed $gitDir to correct path.

2. 7-Zip MSI does not register in system PATH. Registry refresh
   (GetEnvironmentVariable Machine+User) was picking up empty result.
   Fixed: inject sevenZipDir directly into $env:PATH if not present.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Simone
2026-05-10 21:42:29 +02:00
parent c9a9d57b9c
commit 0fd931d6a9
1 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
template/Setup-WinBuild2025.ps1
+5 -4
View File
@@ -991,7 +991,7 @@ if (-not (Test-Path $buildToolsRoot)) {
} }
# ── Git for Windows ─────────────────────────────────────────────────────────── # ── Git for Windows ───────────────────────────────────────────────────────────
$gitDir = Join-Path $buildToolsRoot 'Git' $gitDir = 'C:\Program Files\Git' # default install location for Git for Windows
$gitExe = Join-Path $gitDir 'bin\git.exe' $gitExe = Join-Path $gitDir 'bin\git.exe'
if (Test-Path $gitExe) { if (Test-Path $gitExe) {
@@ -1079,9 +1079,10 @@ if (Test-Path $sevenZipExe) {
Write-Host "7-Zip installed." Write-Host "7-Zip installed."
} }
# Refresh PATH whether freshly installed or already present # 7-Zip MSI does NOT add to system PATH — inject directory directly
$env:PATH = [System.Environment]::GetEnvironmentVariable('PATH', 'Machine') + ';' + if ($env:PATH -notlike "*$sevenZipDir*") {
[System.Environment]::GetEnvironmentVariable('PATH', 'User') $env:PATH = $env:PATH + ";$sevenZipDir"
}
# Validation # Validation
Assert-Step '7-Zip' '7z.exe exists at expected path' { Assert-Step '7-Zip' '7z.exe exists at expected path' {