From 3283109bedfb35f1f13439f9c233259cab58afd7 Mon Sep 17 00:00:00 2001
From: Simone <simone@emulab.it>
Date: Sun, 10 May 2026 21:26:00 +0200
Subject: [PATCH] fix(template): Handle Git version tag vs filename mismatch

GitHub release tag: v2.54.0.windows.1
Filename in release: Git-2.54.0-64-bit.exe (no .windows.1)

Extract base version for filename via regex:
  $gitVersionBase = $GitVersion -replace '\.windows\.\d+$', ''

URL now correctly formed as:
  .../download/v2.54.0.windows.1/Git-2.54.0-64-bit.exe

Reverted GitVersion back to '2.54.0.windows.1' (needed for tag).

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
---
 template/Setup-WinBuild2025.ps1 | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/template/Setup-WinBuild2025.ps1 b/template/Setup-WinBuild2025.ps1
index 4368b33..541c426 100644
--- a/template/Setup-WinBuild2025.ps1
+++ b/template/Setup-WinBuild2025.ps1
@@ -144,7 +144,7 @@ param(
     [string] $AdminPassword = '',
 
     # Git for Windows version (latest stable)
-    [string] $GitVersion = '2.54.0',
+    [string] $GitVersion = '2.54.0.windows.1',
 
     # 7-Zip version (latest stable)
     [string] $SevenZipVersion = '24.07'
@@ -997,7 +997,9 @@ $gitExe = Join-Path $gitDir 'bin\git.exe'
 if (Test-Path $gitExe) {
     Write-Host "Git for Windows already installed: $(& $gitExe --version 2>&1)"
 } else {
-    $gitUrl     = "https://github.com/git-for-windows/git/releases/download/v$GitVersion/Git-$GitVersion-64-bit.exe"
+    # Extract base version (e.g. '2.54.0' from '2.54.0.windows.1') for filename
+    $gitVersionBase = $GitVersion -replace '\.windows\.\d+$', ''
+    $gitUrl     = "https://github.com/git-for-windows/git/releases/download/v$GitVersion/Git-$gitVersionBase-64-bit.exe"
     $gitInstaller = 'C:\CI\git_installer.exe'
 
     Write-Host "Downloading Git for Windows $GitVersion..."
@@ -1007,7 +1009,7 @@ if (Test-Path $gitExe) {
         throw "Failed to download Git from $gitUrl : $_"
     }
 
-    Assert-Hash -FilePath $gitInstaller -Label "Git-$GitVersion-64-bit.exe" `
+    Assert-Hash -FilePath $gitInstaller -Label "Git-$gitVersionBase-64-bit.exe" `
                 -Expected $script:Hashes['GitForWindows']
 
     Write-Host "Installing Git for Windows (silent, with PATH)..."