Simone/local-ci-cd-system
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

perf(template): NSIS download use WebClient instead of IWR (no progress-bar overhead)

Browse Source
This commit is contained in:
Simone
2026-05-11 20:44:50 +02:00
parent 1ad9b4dd4f
commit 364c51b448
1 changed files with 13 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
template/Setup-WinBuild2025.ps1
+13 -10
View File
@@ -1198,33 +1198,36 @@ if (Test-Path $nsisExe) {
} else {
# SourceForge redirect chain:
# Step 1: sf.net/.../download?use_mirror=autoselect → 200 HTML meta-refresh
# The meta-refresh URL is: https://downloads.sourceforge.net/project/nsis/...?ts=TOKEN
# The meta-refresh URL is: https://downloads.sourceforge.net/project/nsis/...?ts=TOKEN&...
# That tokenised URL resolves directly to the binary (no further HTML).
# Strategy: fetch the HTML page, extract the meta-refresh URL, download it immediately
# (the ts= token is short-lived, so we use it right away).
# Strategy: fetch the HTML page via WebClient (faster than IWR — no progress-bar overhead),
# HTML-decode the extracted URL (& → &), then download directly.
$nsisPageUrl = "https://sourceforge.net/projects/nsis/files/NSIS%20$($NSISVersion.Split('.')[0])/$NSISVersion/nsis-$NSISVersion-setup.exe/download?use_mirror=autoselect"
$nsisInstaller = 'C:\CI\nsis_installer.exe'
$sfUA = @{ 'User-Agent' = 'Mozilla/5.0 (Windows NT 10.0; Win64; x64)' }
$sfUserAgent = 'Mozilla/5.0 (Windows NT 10.0; Win64; x64)'
Write-Host "Resolving NSIS $NSISVersion download URL from SourceForge..."
$wc = New-Object System.Net.WebClient
$wc.Headers.Add('User-Agent', $sfUserAgent)
try {
$sfPage = Invoke-WebRequest -Uri $nsisPageUrl -UseBasicParsing -MaximumRedirection 5 `
-Headers $sfUA
$sfHtml = $wc.DownloadString($nsisPageUrl)
} catch { throw "Failed to reach SourceForge download page: $_" }
# Extract tokenised URL from: <meta http-equiv="refresh" content="5; url=https://downloads.sourceforge.net/...?ts=...">
# The HTML may encode & as &amp;, so decode before using the URL.
$nsisCdnUrl = $null
if ($sfPage.RawContent -match 'content="\d+;\s*url=(https://downloads\.sourceforge\.net/[^"]+)"') {
$nsisCdnUrl = $Matches[1]
if ($sfHtml -match 'content="\d+;\s*url=(https://downloads\.sourceforge\.net/[^"]+)"') {
$nsisCdnUrl = [System.Net.WebUtility]::HtmlDecode($Matches[1])
}
if (-not $nsisCdnUrl) {
throw "Could not extract tokenised download URL from SourceForge page for NSIS $NSISVersion. " +
"Page structure may have changed."
}
Write-Host "Downloading NSIS $NSISVersion from SourceForge..."
$wc.Headers.Add('User-Agent', $sfUserAgent) # re-set: DownloadString clears headers
try {
Invoke-WebRequest -Uri $nsisCdnUrl -OutFile $nsisInstaller -UseBasicParsing -Headers $sfUA
} catch { throw "Failed to download NSIS from '$nsisCdnUrl': $_" }
$wc.DownloadFile($nsisCdnUrl, $nsisInstaller)
} catch { throw "Failed to download NSIS from SourceForge: $_" }
# Guard: verify the file is a valid PE executable (MZ magic bytes).
$peBytes = [System.IO.File]::ReadAllBytes($nsisInstaller)