feat(sprint7): §5.1 — Pester smoke tests (no real VM required)

Four test files under tests/ using fake vmrun.cmd (exit code via %FAKE_VMRUN_EXIT% env var) — no VMware or network dependency: _Common.Tests.ps1 — New-CISessionOption TLS flags, Resolve-VmrunPath throw/return, Invoke-Vmrun ExitCode/Output/ThrowOnError New-BuildVM.Tests.ps1 — throw on missing template, throw+cleanup on clone failure, Clone_{JobId}_{timestamp} name format Remove-BuildVM.Tests.ps1 — no-op on missing VMX, partial dir cleanup, -WhatIf preservation, full destroy removes dir Wait-VMReady.Tests.ps1 — throw on missing vmrun, timeout throw, IP ValidatePattern accept/reject Run: Invoke-Pester tests\ -Output Detailed Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-05-10 20:12:19 +02:00
parent 552eb628b7
commit f46e4a8ca3
5 changed files with 365 additions and 16 deletions
@@ -0,0 +1,92 @@
+#Requires -Version 5.1
+<#
+.SYNOPSIS
+    Pester v5 tests for scripts/Wait-VMReady.ps1
+#>
+
+BeforeAll {
+    $script:ScriptPath = Join-Path $PSScriptRoot '..\scripts\Wait-VMReady.ps1'
+
+    # Fake vmrun: getGuestIPAddress exits with %FAKE_VMRUN_EXIT% (default 1 = not ready)
+    $script:FakeVmrun = Join-Path $env:TEMP "fake-vmrun-wait-$PID.cmd"
+    Set-Content $script:FakeVmrun -Value @'
+@echo off
+if "%FAKE_VMRUN_EXIT%"=="" ( exit /b 1 ) else ( exit /b %FAKE_VMRUN_EXIT% )
+'@
+
+    # Fake VMX file — just needs to exist
+    $script:FakeVmx = Join-Path $env:TEMP "fake-wait-$PID.vmx"
+    Set-Content $script:FakeVmx -Value 'config.version = "8"'
+}
+
+AfterAll {
+    Remove-Item $script:FakeVmrun -Force -ErrorAction SilentlyContinue
+    Remove-Item $script:FakeVmx  -Force -ErrorAction SilentlyContinue
+    $env:FAKE_VMRUN_EXIT = $null
+}
+
+# ─────────────────────────────────────────────────────────────────────────────
+Describe 'Wait-VMReady — missing vmrun' {
+    It 'throws when VmrunPath does not exist' {
+        {
+            & $script:ScriptPath `
+                -VMPath    $script:FakeVmx `
+                -IPAddress '192.168.79.101' `
+                -VmrunPath 'C:\DoesNotExist\vmrun.exe'
+        } | Should -Throw
+    }
+}
+
+# ─────────────────────────────────────────────────────────────────────────────
+Describe 'Wait-VMReady — timeout' {
+    It 'throws with timeout message when VM never becomes ready' {
+        $env:FAKE_VMRUN_EXIT = '1'   # vmrun getGuestIPAddress always fails → VM not running
+        {
+            & $script:ScriptPath `
+                -VMPath             $script:FakeVmx `
+                -IPAddress          '192.168.79.101' `
+                -VmrunPath          $script:FakeVmrun `
+                -TimeoutSeconds     5 `
+                -PollIntervalSeconds 2 `
+                -SkipPing
+        } | Should -Throw -ExpectedMessage '*Timed out*'
+    }
+
+    AfterEach { $env:FAKE_VMRUN_EXIT = $null }
+}
+
+# ─────────────────────────────────────────────────────────────────────────────
+Describe 'Wait-VMReady — IP validation' {
+    It 'rejects an invalid IP address' {
+        {
+            & $script:ScriptPath `
+                -VMPath    $script:FakeVmx `
+                -IPAddress '999.999.999.999' `
+                -VmrunPath $script:FakeVmrun
+        } | Should -Throw
+    }
+
+    It 'accepts a valid IP address without immediate error from parameter binding' {
+        # This will still time out (vmrun fake exits 1), but the IP itself must not
+        # cause a parameter validation error — that would throw before the timeout.
+        $env:FAKE_VMRUN_EXIT = '1'
+        $err = $null
+        try {
+            & $script:ScriptPath `
+                -VMPath             $script:FakeVmx `
+                -IPAddress          '192.168.79.101' `
+                -VmrunPath          $script:FakeVmrun `
+                -TimeoutSeconds     3 `
+                -PollIntervalSeconds 2 `
+                -SkipPing `
+                -ErrorAction Stop
+        } catch {
+            $err = $_
+        }
+        # Error must be the timeout, not a parameter validation error
+        "$err" | Should -Match 'Timed out'
+        "$err" | Should -Not -Match 'Cannot validate'
+
+        $env:FAKE_VMRUN_EXIT = $null
+    }
+}