Simone/nsis-plugin-ns7zip
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 8 Wiki Activity

fix(build): pass -prerelease to vswhere (find VS2026)

Browse Source 
VS2026 ships on the prerelease channel; vswhere omits it unless
-prerelease is given. Without it _find_msbuild_via_vswhere returned
nothing, so the path fallback picked an incomplete
(x86)\Microsoft Visual Studio\18\BuildTools install (MSBuild present
but no VC v180 targets) -> MSB4019 on hosts that have VS2026 IDE but
not BuildTools. -prerelease is harmless on the CI VM (BuildTools is
found regardless).

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This commit is contained in:
Simone
2026-05-17 21:57:13 +02:00
parent ea71e0d8b2
commit b052497701
7 changed files with 7 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tools/legacy/build_plugin_2501_vs2022.py
+1
View File
@@ -141,6 +141,7 @@ def _find_msbuild_via_vswhere(vs_version: str) -> 'Optional[Tuple[Path, str, str
str(_VSWHERE_PATH),
'-version', _VS_VERSION_RANGE[ver],
'-latest',
'-prerelease',
'-requires', 'Microsoft.Component.MSBuild',
'-find', r'MSBuild\**\Bin\MSBuild.exe',
],
tools/legacy/build_plugin_2501_vs2026.py
+1
View File
@@ -150,6 +150,7 @@ def _find_msbuild_via_vswhere(vs_version: str) -> 'Optional[Tuple[Path, str, str
'-products', '*',
'-version', _VS_VERSION_RANGE[ver],
'-latest',
'-prerelease',
'-requires', 'Microsoft.Component.MSBuild',
'-find', r'MSBuild\**\Bin\MSBuild.exe',
],
tools/legacy/build_plugin_2600_vs2026.py
+1
View File
@@ -150,6 +150,7 @@ def _find_msbuild_via_vswhere(vs_version: str) -> 'Optional[Tuple[Path, str, str
'-products', '*',
'-version', _VS_VERSION_RANGE[ver],
'-latest',
'-prerelease',
'-requires', 'Microsoft.Component.MSBuild',
'-find', r'MSBuild\**\Bin\MSBuild.exe',
],
tools/legacy/build_plugin_2601_vs2026.py
+1
View File
@@ -150,6 +150,7 @@ def _find_msbuild_via_vswhere(vs_version: str) -> 'Optional[Tuple[Path, str, str
'-products', '*',
'-version', _VS_VERSION_RANGE[ver],
'-latest',
'-prerelease',
'-requires', 'Microsoft.Component.MSBuild',
'-find', r'MSBuild\**\Bin\MSBuild.exe',
],
tools/legacy/build_plugin_vs2022.py
+1
View File
@@ -146,6 +146,7 @@ def _find_msbuild_via_vswhere(vs_version: str) -> 'Optional[Tuple[Path, str, str
str(_VSWHERE_PATH),
'-version', _VS_VERSION_RANGE[ver],
'-latest',
'-prerelease',
'-requires', 'Microsoft.Component.MSBuild',
'-find', r'MSBuild\**\Bin\MSBuild.exe',
],
tools/legacy/build_plugin_vs2026.py
+1
View File
@@ -150,6 +150,7 @@ def _find_msbuild_via_vswhere(vs_version: str) -> 'Optional[Tuple[Path, str, str
'-products', '*',
'-version', _VS_VERSION_RANGE[ver],
'-latest',
'-prerelease',
'-requires', 'Microsoft.Component.MSBuild',
'-find', r'MSBuild\**\Bin\MSBuild.exe',
],
tools/legacy/build_plugin_zstd_vs2026.py
+1
View File
@@ -150,6 +150,7 @@ def _find_msbuild_via_vswhere(vs_version: str) -> 'Optional[Tuple[Path, str, str
'-products', '*',
'-version', _VS_VERSION_RANGE[ver],
'-latest',
'-prerelease',
'-requires', 'Microsoft.Component.MSBuild',
'-find', r'MSBuild\**\Bin\MSBuild.exe',
],