From ef88d32877c43a4473651fb254e96219cce7a4b5 Mon Sep 17 00:00:00 2001 From: Simone Date: Thu, 30 Apr 2026 22:44:48 +0200 Subject: [PATCH] fix: align Release UNICODE config name with vcxproj; use --config in CI --- .github/workflows/build.yml | 2 +- .github/workflows/release.yml | 2 +- build_plugin.py | 5 ++--- 3 files changed, 4 insertions(+), 5 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index cc5ed68..4fe517a 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -52,7 +52,7 @@ jobs: "version=$v" | Out-File -FilePath $env:GITHUB_OUTPUT -Append - name: Build ${{ matrix.config }} - run: python build_plugin.py --configs ${{ matrix.config }} --verbosity minimal + run: python build_plugin.py --config ${{ matrix.config }} --verbosity minimal - name: Upload DLL uses: actions/upload-artifact@v4 diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 02afedf..e4cf67d 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -36,7 +36,7 @@ jobs: - uses: microsoft/setup-msbuild@v2 - name: Build ${{ matrix.config }} - run: python build_plugin.py --configs ${{ matrix.config }} + run: python build_plugin.py --config ${{ matrix.config }} - name: Determine version & arch id: meta diff --git a/build_plugin.py b/build_plugin.py index ff663ee..6775733 100644 --- a/build_plugin.py +++ b/build_plugin.py @@ -145,8 +145,8 @@ class BuildConfig: CONFIGS = { 'x86-ansi': BuildConfig('x86-ansi', 'Release', 'Win32', 'x86-ansi'), - 'x86-unicode': BuildConfig('x86-unicode', 'Release Unicode', 'Win32', 'x86-unicode'), - 'x64-unicode': BuildConfig('x64-unicode', 'Release Unicode', 'x64', 'amd64-unicode'), + 'x86-unicode': BuildConfig('x86-unicode', 'Release UNICODE', 'Win32', 'x86-unicode'), + 'x64-unicode': BuildConfig('x64-unicode', 'Release UNICODE', 'x64', 'amd64-unicode'), } DLL_NAME = 'nsProcess.dll' @@ -677,4 +677,3 @@ def main() -> int: if __name__ == '__main__': sys.exit(main()) -