Simone/i2c-imc-skylake
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

i2c-imc-skylake: warn when SMBCNTL cannot be read

Browse Source 
The TSOD-polling check silently skipped a channel whose SMBCNTL read
failed, so on a system without ECAM the driver bound with the check
silently not performed.  Binding is still allowed - the register is
best-effort on top of the allow_unsafe_access gate, like the existing
warning when no iMC channel function is found - but say so in the log
instead of pretending the check ran.
This commit is contained in:
Simone
2026-07-28 09:42:27 +02:00
parent 694ed6a712
commit 72b6b7b9f2
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
i2c-imc-skylake.c
+5 -1
View File
@@ -597,8 +597,12 @@ static int imc_check_firmware_polling(struct pci_dev *pdev)
for (i = 0; i < ARRAY_SIZE(imc_chans); i++) {
u32 cntl;
if (pci_read_config_dword(imc, IMC_SMBCNTL(i), &cntl))
if (pci_read_config_dword(imc, IMC_SMBCNTL(i), &cntl)) {
dev_warn(&pdev->dev,
"%s ch%d SMBCNTL unreadable; cannot verify that TSOD polling is disabled\n",
pci_name(imc), i);
continue;
}
if (cntl & SMBCNTL_TSOD_POLL_EN) {
dev_err(&pdev->dev,