0726829c5c
The python lint job set VENV_DIR=F:\CI\python\venv (the shared orchestrator venv) and ran `pip install -e ".[dev]"`. Every lint run repointed ci_orchestrator at the lint job's transient checkout; once act_runner cleaned that dir, all later smoke/build jobs failed with "No module named ci_orchestrator". Use a job-local venv under github.workspace, rebuilt fresh each run. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
140 lines
4.6 KiB
YAML
140 lines
4.6 KiB
YAML
# PSScriptAnalyzer + Python lint — runs on every push/PR that touches code files.
|
|
# Requires PSScriptAnalyzer installed on the runner host:
|
|
# Install-Module PSScriptAnalyzer -Scope AllUsers -Force
|
|
#
|
|
# Failures block the PR. Fix warnings with:
|
|
# Invoke-ScriptAnalyzer -Path scripts\ -Recurse -Fix
|
|
|
|
|
|
name: Lint
|
|
|
|
on:
|
|
workflow_dispatch:
|
|
push:
|
|
paths:
|
|
- '**.ps1'
|
|
- '**.psm1'
|
|
- '**.py'
|
|
- 'pyproject.toml'
|
|
- '.gitea/workflows/lint.yml'
|
|
pull_request:
|
|
paths:
|
|
- '**.ps1'
|
|
- '**.psm1'
|
|
- '**.py'
|
|
- 'pyproject.toml'
|
|
- '.gitea/workflows/lint.yml'
|
|
|
|
jobs:
|
|
pssa:
|
|
runs-on: windows-build
|
|
timeout-minutes: 10
|
|
|
|
steps:
|
|
- name: Checkout
|
|
uses: actions/checkout@v4
|
|
with:
|
|
fetch-depth: 1
|
|
|
|
- name: Run PSScriptAnalyzer
|
|
shell: powershell
|
|
run: |
|
|
$ErrorActionPreference = 'Stop'
|
|
|
|
if (-not (Get-Module -ListAvailable PSScriptAnalyzer)) {
|
|
Write-Host "Installing PSScriptAnalyzer..."
|
|
Install-Module PSScriptAnalyzer -Scope CurrentUser -Force -AllowClobber
|
|
}
|
|
|
|
$settings = Join-Path $PWD 'PSScriptAnalyzerSettings.psd1'
|
|
$paths = @('scripts', 'template', 'Setup-Host.ps1')
|
|
$results = $paths | ForEach-Object {
|
|
if (Test-Path $_) {
|
|
Invoke-ScriptAnalyzer -Path $_ -Recurse -Settings $settings -Severity Error,Warning
|
|
}
|
|
}
|
|
|
|
if ($results) {
|
|
$results | Format-Table -AutoSize
|
|
Write-Error "PSScriptAnalyzer found $($results.Count) issue(s). Fix before merging."
|
|
exit 1
|
|
}
|
|
else {
|
|
Write-Host "PSScriptAnalyzer: no issues found."
|
|
}
|
|
|
|
python:
|
|
runs-on: windows-build
|
|
timeout-minutes: 20
|
|
|
|
env:
|
|
PYTHONIOENCODING: utf-8
|
|
# Job-local, ephemeral venv. MUST NOT be the production venv
|
|
# (F:\CI\python\venv): an editable install here would repoint the
|
|
# shared orchestrator package at this run's transient checkout and
|
|
# break every later smoke/build job with "No module named
|
|
# ci_orchestrator". github.workspace is discarded after the job.
|
|
VENV_DIR: ${{ github.workspace }}\.venv-lint
|
|
|
|
steps:
|
|
- name: Checkout
|
|
uses: actions/checkout@v4
|
|
with:
|
|
fetch-depth: 1
|
|
|
|
- name: Setup venv + install package
|
|
shell: powershell
|
|
run: |
|
|
$ErrorActionPreference = 'Stop'
|
|
|
|
# Production venv lives at $env:VENV_DIR (F:\CI\python\venv per AGENTS.md).
|
|
# The system Python used to bootstrap it is configured once in
|
|
# runner/config.yaml as CI_PYTHON_LAUNCHER (single source of truth).
|
|
if (-not $env:CI_PYTHON_LAUNCHER) {
|
|
throw "CI_PYTHON_LAUNCHER not set. Configure it in runner/config.yaml (runner.envs) and restart act_runner."
|
|
}
|
|
if (-not (Test-Path $env:CI_PYTHON_LAUNCHER)) {
|
|
throw "CI_PYTHON_LAUNCHER points to '$env:CI_PYTHON_LAUNCHER' which does not exist."
|
|
}
|
|
|
|
$venvPy = Join-Path $env:VENV_DIR 'Scripts\python.exe'
|
|
|
|
# Always build a fresh, job-local venv. Never reuse or repair a
|
|
# shared one — lint must be fully isolated from the production
|
|
# orchestrator venv.
|
|
if (Test-Path $env:VENV_DIR) {
|
|
Remove-Item $env:VENV_DIR -Recurse -Force
|
|
}
|
|
& $env:CI_PYTHON_LAUNCHER -m venv $env:VENV_DIR
|
|
if ($LASTEXITCODE -ne 0) { throw "venv creation failed" }
|
|
|
|
Write-Host "Using venv python: $venvPy"
|
|
& $venvPy --version
|
|
if ($LASTEXITCODE -ne 0) { throw "python --version failed" }
|
|
|
|
& $venvPy -m pip install --upgrade pip
|
|
if ($LASTEXITCODE -ne 0) { throw "pip upgrade failed" }
|
|
& $venvPy -m pip install -e ".[dev]"
|
|
if ($LASTEXITCODE -ne 0) { throw "pip install failed" }
|
|
|
|
- name: ruff
|
|
shell: powershell
|
|
run: |
|
|
$venvPy = Join-Path $env:VENV_DIR 'Scripts\python.exe'
|
|
& $venvPy -m ruff check src tests/python
|
|
if ($LASTEXITCODE -ne 0) { throw "ruff failed" }
|
|
|
|
- name: mypy --strict
|
|
shell: powershell
|
|
run: |
|
|
$venvPy = Join-Path $env:VENV_DIR 'Scripts\python.exe'
|
|
& $venvPy -m mypy --strict src
|
|
if ($LASTEXITCODE -ne 0) { throw "mypy failed" }
|
|
|
|
- name: pytest (coverage >= 90%)
|
|
shell: powershell
|
|
run: |
|
|
$venvPy = Join-Path $env:VENV_DIR 'Scripts\python.exe'
|
|
& $venvPy -m pytest tests/python --cov=ci_orchestrator --cov-fail-under=90
|
|
if ($LASTEXITCODE -ne 0) { throw "pytest failed" }
|